You will recieve your password to this address. Address is not made public.

Your preferred username that is used when logging in.

Logic error in copyProps Created Nov 1, 2009

This thread is solved

Views: 462     Replies: 3     Last reply Nov 18, 2009  
You must login first before you can use this feature

jjinux
In this life we cannot do great things. We can only do small things with great love. -- Mother Teresa http://jjinux.blogspot.com/

Posts: 23

Registered:
Oct 29, 2009

Logic error in copyProps

Posted: Nov 1, 2009

I'm looking at flowplayer.core/src/actionscript/org/flowplayer/config/Config.as. In the copyProps function, I see:


            if (source is Number || source is String || source is Array) {
                target = source;
                return target;
            }

            if (source is Array) {

"source is Array" is checked twice. I don't think that that second if statement will ever get triggered.

Happy Hacking!

jjinux
In this life we cannot do great things. We can only do small things with great love. -- Mother Teresa http://jjinux.blogspot.com/

Posts: 23

Registered:
Oct 29, 2009

What is "props" for?

Posted: Nov 1, 2009

Reply to: Logic error in copyProps, from jjinux
Looking at the code, I also can't figure out what "props" is for. It's being set, but I don't see any place where it's being used.

Anssi
Flowplayer Flash & video streaming developer

Posts: 912

Registered:
Jul 24, 2007

» What is "props" for?

Posted: Nov 1, 2009

Reply to: What is "props" for?, from jjinux
Yep, these are now fixed and committed.

jjinux
In this life we cannot do great things. We can only do small things with great love. -- Mother Teresa http://jjinux.blogspot.com/

Posts: 23

Registered:
Oct 29, 2009

Thanks!

Posted: Nov 18, 2009

Reply to: » What is "props" for?, from Anssi
Thanks!