history plugin: fix for hash-less initial urls Created Jun 3, 2010

I'm having nothing but problems with this. I can't believe i have to download the history plugin separately and then make and edit to the core files. are you guys serious?

FWIW, i posted some history fixes to the github bugreporting, which seem to solve all issues i experienced with the plugin. the "fix" above is a bit outdated. not sure any dev cares tho, the problems reported for 1.2.2 are still in the latest 1.2.3 version...

yea, that's absurd. It's like these guys got the concept right for how to do this stuff, but they have just totally screwed up on so many of the details. this library is a complete pain to work with, and then when you start digging into it and you see stuff like this, it just makes you want to jump out a window.

not only that, it's nearly all trial and error to figure out why things don't work. their demo's and explinations are piss poor at really helping you understand what's going on and they consistantly leave out critical information.

i think i need to find a new effects library for this stuff. these guys clearly don't care if they do it right or not.

Link to the bug report:

http://github.com/jquerytools/jquerytools/issues/#issue/77

Code for the history plugin:

http://github.com/jquerytools/jquerytools/blob/master/src/toolbox/toolbox.history.js

Easy to reproduce:

With history on, ie and ff show hash mark at end of url (as the result of internally generated "click") when first going to page. Then to create error in IE (including version 8), hit *refresh* (now with the trailing hash mark on the url).

ff succeeds, but ie generates error (from within jquery itself, complaining about uncaught error within jquery library line 2904:

Sizzle.error = function( msg ) {
	 throw "Syntax error, unrecognized expression: " + msg;
};

where msg="#") and shuts down javascript.

(Chrome doesn't generate hash mark, nor the problem).

I've had to turn history off until I find a workaround.

- Henrik

I've downloaded a version of query tools library *without* history, then downloaded history separately, linked it separately, and made the change in the history code that heldchen suggested.

That fixed the problem, but of course now I'm running a fork, not good.

I have to agree with the other writers that this is not very impressive QA. Possible to organize a QA group?

There's a design perspective on this as well: what sense does it make to have an empty hash after a url in the first place? It generates an extra unnecessary back button action required of the user. One click to get in, two to get out. This is the sort of nuisance that can confound and frustrate users, undermining confidence.

- Henrik

To reproduce the problem, do the following:

1. Go to http://flowplayer.org/tools/demos/tabs/ajax-history.html with IE (I'm using IE 8)
2. Note that the history plugin adds a trailing hash (#) to the url
3. Hit refresh on the browser
4. Note that javascript has crashed (note error indicator in IE status bar, and that no content appears in tab pane).

Needless to say this is a critical bug.

Hope this helps.

- Henrik