You will recieve your password to this address. Address is not made public.

Your preferred username that is used when logging in.

Issue with Slideshow plugin Created Sep 28, 2009

This thread is solved

Views: 914     Replies: 3     Last reply Oct 7, 2009  
You must login first before you can use this feature

backdark

Posts: 2

Registered:
Sep 23, 2009

Issue with Slideshow plugin

Posted: Sep 28, 2009

Hi there is an issue with the new event model in 1.1.1 and the slideshow plugin. The new event model requires to add an event and breaks handling of the next and prev features in the slideshow plugin.

Adding a event parameter to the onBeforeClick handler seems to solve the issue.

tools.tabs.slideshow-1.0.1.js
line 171
onBeforeClick(function(i) {

becomes
api.onBeforeClick(function(event, i) {

Can you guys have a quick look please?

Just a quick question since I struggled a bit to find out and my javascript background is quite light, what tool set are you using to develop the library? Do you have any automated testing procedure?

Anyway thanks for the great lib!

Regards

Alexandre

Tero
Author of jQuery Tools and this website + JavaScript developer of Flowplayer.

Posts: 1867

Registered:
Nov 16, 2007

» Issue with Slideshow plugin

Posted: Oct 5, 2009

Reply to: Issue with Slideshow plugin, from backdark
Our demo page works just fine:

http://flowplayer.org/tools/demos/tabs/slideshow.html

The next/prev buttons work as well as an API call:


$("div.tabs").tabs().next()

Do you have a sample page to look at?

backdark

Posts: 2

Registered:
Sep 23, 2009

» » Issue with Slideshow plugin

Posted: Oct 5, 2009

Reply to: » Issue with Slideshow plugin, from tipiirai
Hi,

I can't easily show you our setup, however it's very easy to reproduce using the example athttp://flowplayer.org/tools/demos/tabs/slideshow.htm

(the standalone sample).
I just saved the html and changed "rotate" to false.

Cycle through the tabs and you'll see at the last tab the next button won't go away and neither the prev one when you go back to the first tab.

When rotating is set to true, there is no need to show/hide the prev/next buttons, so there is no apparent bug.

Tero
Author of jQuery Tools and this website + JavaScript developer of Flowplayer.

Posts: 1867

Registered:
Nov 16, 2007

» » » Issue with Slideshow plugin

Posted: Oct 7, 2009

Reply to: » » Issue with Slideshow plugin, from backdark
THANKS! This is now fixed and the fixed release will be released today.

•